Skip to content

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 23, 2025

Which issue does this PR close?

Fixed[16] encoded UUIDs are now supported in Avro-rs: apache/avro-rs#255

This will automatically support String and Fixed[16] logical types if the logicalType annotation is set correctly 👍

What changes are included in this PR?

Are these changes tested?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const MAP_LOGICAL_TYPE: &str = "map";
// # TODO: https://github.com/apache/iceberg-rust/issues/86
// This const may better to maintain in avro-rs.
const LOGICAL_TYPE: &str = "logicalType";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried but couldnt find this constant exposed by avro-rs

@kevinjqliu kevinjqliu merged commit 33d97ba into apache:main Sep 24, 2025
16 checks passed
DerGut pushed a commit to DerGut/iceberg-rust that referenced this pull request Oct 6, 2025
## Which issue does this PR close?

`Fixed[16]` encoded UUIDs are now supported in Avro-rs:
apache/avro-rs#255

This will automatically support String and Fixed[16] logical types if
the `logicalType` annotation is set correctly 👍

## What changes are included in this PR?

<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->

## Are these changes tested?

<!--
Specify what test covers (unit test, integration test, etc.).

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants