Skip to content

Commit 5414c30

Browse files
joemcdonnellImpala Public Jenkins
authored andcommitted
IMPALA-13809: Update list of excluded locations for the code coverage report
This adds be/src/gutil and be/src/kudu to the list of excluded locations for the code coverage report. These directories are third-party party code that have been vendored into the Impala repository. There is a fair amount of unused code in those directories simply because it is easier to maintain that way. Impala's tests aren't intending to test that code. Testing: - Ran code coverage with the updated list Change-Id: I7f3aa971e50b2c454e9ca607fb9d49d7cc3593ae Reviewed-on: http://gerrit.cloudera.org:8080/23084 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
1 parent 5bdd9c7 commit 5414c30

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

bin/coverage_helper.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ if [ ${REPORT_ACTION} -eq 1 ]; then
7777
cd "${IMPALA_HOME}"
7878
"${IMPALA_HOME}/bin/impala-gcovr" -v -r "${IMPALA_HOME}/be" \
7979
--exclude=".*src/benchmarks.*" \
80+
--exclude=".*src/gutil.*" \
81+
--exclude=".*src/kudu.*" \
8082
--exclude=".*generated-sources/gen-cpp.*" \
8183
--exclude=".*src/util/bit-packing.inline.h.*" \
8284
--html --html-details -o "${REPORT_DIRECTORY}/index.html" \

0 commit comments

Comments
 (0)