KOGITO-5725: Enable extensions for github.dev
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caponetto
changed the title
github.devgithub.dev
caponetto
changed the title
github.devgithub.dev
|
Hi @caponetto , I am sorry but I don't have time to take a look on this PR this week. I also asked others from QE and they are also busy. I can take a look next week. |
Manual sanity checks
|
jomarko
approved these changes
Sep 17, 2021
tiagobento
approved these changes
Sep 17, 2021
vpellegrino
pushed a commit
to vpellegrino/kie-tools
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all necessary changes to run the extensions on
github.dev. Details are described in the official guide.Extensions that will be enabled:
vscode-extension-bpmn-editor(prod)vscode-extension-dmn-editor(prod)vscode-extension-pmml-editor(prod)vscode-extension-pack-kogito-kie-editors(dev)Note: Bundles cannot be enabled.
The way to test the extensions on the browser is to use the @vscode/test-web package.
It basically opens VS Code on the browser, allowing tests closer to the actual
github.devenv.To run this, use the new
yarn run:webmodescript that is available for each extension.Known issues: The Resource Content API does not seem to be working on this
vscode-test-webenv.This means that importing WIDs (BPMN), included models (DMN), and search for DMNs (SCESIM) can't be validated.
There's an open issue to better understand this behavior.
Also, I wasn't able to resize the window and I've seen some issues with importing folders.
Anyway, the most important thing here is that, after these changes, the extensions keep working as expected on the desktop.