[NETBEANS-308] remove 3 JavaFX samples re stock photos discussion #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems OK to me. |
jlahoda
approved these changes
Apr 2, 2018
matthiasblaesing
approved these changes
Apr 2, 2018
|
I obviously would not be ok with removing functionality/artwork from the IDE itself either. :-) |
ocafebabe
pushed a commit
to ocafebabe/incubator-netbeans
that referenced
this pull request
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding discussion re licensing of stock photos (note that the discussion shouldn't be needed, since these have been donated and hence belong to Apache, but a discussion was started about this in the IPMC vote for rc3 of the Beta 9.0 release anyway) by simply removing the JavaFX samples that contain them.