Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Service's start & stop & restart through Cli #846

Open
2 of 3 tasks
Tracked by #758
smallzhongfeng opened this issue Apr 27, 2023 · 3 comments
Open
2 of 3 tasks
Tracked by #758

[Subtask] Service's start & stop & restart through Cli #846

smallzhongfeng opened this issue Apr 27, 2023 · 3 comments
Assignees
@slfan1989

Comments

@smallzhongfeng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Start services through cli (including shuffleServer, coordinator)

Parent issue

#758

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@smallzhongfeng smallzhongfeng self-assigned this Apr 27, 2023
@slfan1989
Copy link
Collaborator

@smallzhongfeng Can you assign this issue to me?

@smallzhongfeng smallzhongfeng mentioned this issue Apr 27, 2023
Open
9 tasks
@smallzhongfeng smallzhongfeng changed the title [Subtask] Service's start & stop & restart through Cli [Subtask] Service's start & stop & restart through Cli Apr 27, 2023
@slfan1989 slfan1989 mentioned this issue Apr 27, 2023
Merged
@slfan1989
Copy link
Collaborator

I will submit the code as soon as possible, 2-3days.

@jerqi
Copy link
Contributor

jerqi commented May 27, 2023 •
edited
Loading

I will submit the code as soon as possible, 2-3days.

@slfan1989 We usually use rest api to control admin service. If we need add api, we would better add rest api. Could we keep consistent with other operation. You can refer to #684

slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 4, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
385aa91
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 20, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
6d396ef
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 21, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
d585a36
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 21, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
f13c864
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 21, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
0c671c8
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 21, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
e8ac35a
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 19, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
3917e1c
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 19, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
a14298a
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 19, 2023
[apache#846] feat(cli): Service's start & stop & restart through Cli.
344f929
jerqi pushed a commit that referenced this issue Jul 19, 2023
@slfan1989
[#846] feat(cli): Service's start & stop & restart through Cli. (#925)
c4bb758 
### What changes were proposed in this pull request?

We support starting and stopping services using CLI commands.

- Command 1: uniffle --daemon start coordinator

```
coordinator start success, is running as process 61743.
```

- Command 2: uniffle --daemon stop coordinator

```
coordinator stop success.
```

- Command 3: uniffle --daemon status coordinator

> If the service is started

```
coordinator is running as process 62087.
```

> If the service is stoped
```
coordinator is stopped.
```


### Why are the changes needed?

Supporting service start and stop functionality using CLI commands is part of this PR.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Testing environment verification.

Co-authored-by: slfan1989 <louj1988@@>
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 28, 2023
[apache#846] feat(cli): Fix CheckStyle.
4ab6218
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 28, 2023
[apache#846] feat(cli): Fix Junit Test.
7939489
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 2, 2023
[apache#846] feat(cli): Fix Junit Test.
b58ef1e
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 5, 2023
[apache#846] feat(cli): Fix Junit Test.
8147240
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 5, 2023
[apache#846] feat(cli): Fix Junit Test.
0c86cce
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 5, 2023
[apache#846] feat(cli): Fix Junit Test.
44e58b9
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 5, 2023
[apache#846] feat(cli): Fix Junit Test.
53b84f6
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 5, 2023
[apache#846] feat(cli): Fix Junit Test.
d351571
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 8, 2023
[apache#846] feat(cli): Fix CheckStyle.
7b1adae
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 8, 2023
[apache#846] feat(cli): Fix CheckStyle.
ed53144
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 8, 2023
[apache#846] feat(cli): Fix CheckStyle.
1bf9a72
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 8, 2023
[apache#846] feat(cli): Fix CheckStyle.
a16a99c
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 8, 2023
[apache#846] feat(cli): Fix CheckStyle.
3d15f90
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 9, 2023
[apache#846] feat(cli): Fix CheckStyle.
bc2c87a
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Aug 9, 2023
[apache#846] feat(cli): Fix CheckStyle.
8f90bf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slfan1989 slfan1989

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jerqi @slfan1989 @smallzhongfeng