-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#846] feat(cli): Service's start & stop & restart through Cli. #925
Conversation
Completed the first version, will continue to improve the code and test it in the testing environment. Currently, it is not ready for review yet. |
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
============================================
+ Coverage 53.67% 54.82% +1.14%
- Complexity 2521 2526 +5
============================================
Files 382 362 -20
Lines 21646 19305 -2341
Branches 1795 1795
============================================
- Hits 11619 10584 -1035
+ Misses 9323 8092 -1231
+ Partials 704 629 -75 see 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d585a36
to
f13c864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @slfan1989
@jerqi Thank you for helping to review the code! I will add some comments to make the code more readable. |
ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2!
@slfan1989 Is this pr ready for merging? |
d1a9574
to
3917e1c
Compare
@jerqi @smallzhongfeng Can you help to review this pr again? Thank you very much! I and @yl09099 have verified with the production environment. |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks all. Merged to master.
What changes were proposed in this pull request?
We support starting and stopping services using CLI commands.
Why are the changes needed?
Supporting service start and stop functionality using CLI commands is part of this PR.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Testing environment verification.