[INLONG-2759][Manager] Fix InlongGroup object deletion and modification exception #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older only has the sort-dist-*.jar file
…longGroupController_update
… 100 2. Add the annotation @ApiModelProperty to the status field of the InlongGroupRequest object to receive front-end parameters for state switching verification 3. The InlongGroupProcessOperation deleteProcess() function adds the delete state 40, otherwise the state verification will fail when the subsequent inner layer calls the groupService.update() method
healchow
reviewed
Feb 27, 2022
...ger-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupRequest.java
Show resolved
Hide resolved
|
It is not recommended to associate 2 or more issues in one PR. |
healchow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title Name: [INLONG-2759][INLONG-2760][Manager] Fix InlongGroup object deletion and modification exception
Fixes #2759 Manager module
First of all, the reason is that the GroupState.forCode() function has passed a null value. The reason is that the request object InlongGroupRequest does not add the annotation @ApiModelProperty() to the status field, which has been fixed here.
But there is still a problem with retesting with annotations, because the front-end page does not pass in the status parameter.
Then continue to use the postman tool to form the status parameter for testing. A new problem has arisen: Current state=wait_submit is not allowed to transfer to state=wait_submit
This is because there is no conversion from GROUP_WAIT_SUBMIT to GROUP_WAIT_SUBMIT in the status transition. The above scenario should be missed here, so I fixed it and tested it again through the post. Finally verified successfully
Finally, the front-end Dashborad module needs to be repaired and the status parameter added.
Fixes #2760
Because the deletion actually calls the groupProcessOperation.deleteProcess() function, the InlongGroupRequest queried according to the id does not change the state. In the inner layer, the groupService.update(groupInfo, username) method is actually executed first. equivalent to the original state of transformation
After repairing and testing again, the interface can return successfully
