Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2759][Manager] Fix InlongGroup object modification exception #2769

Closed
wants to merge 6 commits into from

Conversation

Greedyu
Copy link
Contributor

@Greedyu Greedyu commented Feb 27, 2022

Title Name: [INLONG-2759][Manager] Fix InlongGroup object modification exception

Fixes #2759

First of all, the reason is that the GroupState.forCode() function has passed a null value. The reason is that the request object InlongGroupRequest does not add the annotation @ApiModelProperty() to the status field.

Originally, an annotation was added to the status field, but the reviewer believes that the status should not be set in the request, and there may be abnormal status flow caused by front-end parameters. We should handle state in the backend system.
image

Then continue to use the postman tool to form the status parameter for testing. A new problem has arisen: Current state=wait_submit is not allowed to transfer to state=wait_submit
image

This is because there is no conversion from GROUP_WAIT_SUBMIT to GROUP_WAIT_SUBMIT in the status transition. The above scenario should be missed here, so I fixed it and tested it again through the post. Finally verified successfully

image

The state needs to be controlled in the interface, and the background business logic is required later here.

@Greedyu
Copy link
Contributor Author

Greedyu commented Mar 4, 2022

has been fixed

@Greedyu Greedyu closed this Mar 4, 2022
@Greedyu Greedyu deleted the bugfix-manager_group_status branch May 7, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] InlongGroupController update interface status problem
3 participants