Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-5621][SDK] Support multi-topic fetcher for Pulsar #5625

Merged
merged 5 commits into from
Aug 24, 2022
Merged

[INLONG-5621][SDK] Support multi-topic fetcher for Pulsar #5625

merged 5 commits into from
Aug 24, 2022

Conversation

vernedeng
Copy link
Contributor

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

  1. Defination of basic class of multi-topic fetcher
  2. Support one pulsar consumer subscribe multi topics at the same time.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng changed the title [INLONG-5621][SDK] support multi-topic pulsar fetcher [INLONG-5621][SDK] Support multi-topic pulsar fetcher Aug 22, 2022
luchunliang
luchunliang approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow changed the title [INLONG-5621][SDK] Support multi-topic pulsar fetcher [INLONG-5621][SDK] Pulsar supports multi-topic fetcher Aug 24, 2022
@healchow healchow changed the title [INLONG-5621][SDK] Pulsar supports multi-topic fetcher [INLONG-5621][SDK] Support multi-topic fetcher for Pulsar Aug 24, 2022
@vernedeng vernedeng mentioned this pull request Aug 24, 2022
Merged
3 tasks
@healchow healchow merged commit 14cff90 into apache:master Aug 24, 2022
@vernedeng vernedeng deleted the INLONG-5621 branch May 26, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doleyzi doleyzi doleyzi approved these changes

@healchow healchow healchow approved these changes

@EMsnap EMsnap EMsnap approved these changes

@luchunliang luchunliang luchunliang approved these changes

Assignees
No one assigned
Labels
component/sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Support multi-topic fetcher for Pulsar
5 participants
@vernedeng @luchunliang @EMsnap @healchow @doleyzi