Skip to content

[INLONG-5623][SDK] Support multi-topic fetcher for Kafka#5659

Merged
dockerzhang merged 7 commits intoapache:masterfrom
vernedeng:INLONG-5623
Aug 25, 2022
Merged

[INLONG-5623][SDK] Support multi-topic fetcher for Kafka#5659
dockerzhang merged 7 commits intoapache:masterfrom
vernedeng:INLONG-5623

Conversation

@vernedeng
Copy link
Copy Markdown
Contributor

Motivation

  1. Introduce skiplist to maintain the offset commit of each TopicPartitions
  2. The costomized msgOffset is different from KafkaSingleTopicFetcher, which is consist of topic:partitionId:offset.

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Copy Markdown
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow changed the title [INLONG-5623][SDK] Support kafka multi topics fetcher [INLONG-5623][SDK] Support multi-topic fetcher for Kafka Aug 24, 2022
@dockerzhang dockerzhang merged commit f8d7f8b into apache:master Aug 25, 2022
@vernedeng vernedeng deleted the INLONG-5623 branch May 26, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Support multi-topic fetcher for Kafka

6 participants