Skip to content

JCR-3928: Add pathStyleAccess flag #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

JCR-3928: Add pathStyleAccess flag #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jackrabbit-aws-ext/src/main/java/org/apache/jackrabbit/aws/ext/S3Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ public final class S3Constants {
*/
public static final String PROXY_PORT = "proxyPort";

/**
* Path style access flag true/false
*/
public static final String S3_PATH_STYLE_ACCESS = "pathStyleAccess";

/**
* private constructor so that class cannot initialized from outside.
*/
Expand Down
7 changes: 7 additions & 0 deletions jackrabbit-aws-ext/src/main/java/org/apache/jackrabbit/aws/ext/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.amazonaws.regions.Regions;
import com.amazonaws.services.s3.AmazonS3;
import com.amazonaws.services.s3.AmazonS3Client;
import com.amazonaws.services.s3.S3ClientOptions;
import com.amazonaws.services.s3.model.ObjectListing;
import com.amazonaws.services.s3.model.Region;
import com.amazonaws.services.s3.model.S3ObjectSummary;
Expand Down Expand Up @@ -126,6 +127,7 @@ public static AmazonS3Client openService(final Properties prop) {
*/
s3service.setEndpoint(endpoint);
LOG.info("S3 service endpoint [{}] ", endpoint);
s3service.setS3ClientOptions(getS3ClientOptions(prop));
return s3service;
}

Expand Down Expand Up @@ -224,4 +226,9 @@ private static ClientConfiguration getClientConfiguration(Properties prop) {
return cc;
}

private static S3ClientOptions getS3ClientOptions(Properties prop) {
boolean pathStyleAccess = Boolean.parseBoolean(prop.getProperty(S3Constants.S3_PATH_STYLE_ACCESS));
return S3ClientOptions.builder().setPathStyleAccess(pathStyleAccess).build();
}

}