KAFKA-13442: REST API endpoint for fetching a connector's config def #11491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition This commit introduces the config definition endpoint for Kafka Connect.
viktorsomogyi
force-pushed
the
KAFKA-13442-configdef-endpoint
branch
from
30043b7
to
5befc06
Compare
|
That looks similar to the KIP I proposed a few weeks ago: https://cwiki.apache.org/confluence/display/KAFKA/KIP-769%3A+Connect+API+to+retrieve+connector+configuration+definitions |
|
@mimaison hahh, thanks, I tried looking for an existing KIP but couldn't find any. Wanted to publish this KIP yesterday but it seems like you were faster. I'll keep on commenting and pushing your KIP then. :) |
|
I want to make a few changes to the KIP before restarting the discussion on the mailing list. Hopefully later on this week (or early next!) |
|
ok, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new Connect REST endpoint to fetch the config definition of a connector. This new API uses the HTTP GET method and is under the /connector-plugins/{connector-type}/config path.
The motivation of this is that some UI management tools could benefit from fetching the config definitions to help the user with a sample connector configuration. Using the config definition of the connector for sample generation is an easy way to solve this problem.
Committer Checklist (excluded from commit message)