Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-1981 Make log compaction point configurable #1168

Closed
wants to merge 17 commits into from

Conversation

ewasserman
Copy link
Contributor

@jkreps

Implements control over the portion of the head of the log that will not be compacted (i.e. preserved in detail).

The log cleaner can be configured retain a minimum amount of the uncompacted "head" of the log.
This is enabled by setting one or more of the compaction lags:

log.cleaner.min.compaction.lag.ms
log.cleaner.min.compaction.lag.bytes
log.cleaner.min.compaction.lag.messages

with similar per topic configurations:

min.compaction.lag.ms
min.compaction.lag.bytes
min.compaction.lag.messages

These can be used to set constraints on the minimum message age, aggregate size, and/or count respectively that may be compacted. If none are set, all log segments are eligible for compaction except for the last segment, i.e. the one currently being written to. The active segment will not be compacted even if all of the compaction lag constraints are satisfied.

In particular this allows for the example use case described in the JIRA: "any consumer that is no more than 1 hour behind will get every message."

This contribution is my (Eric Wasserman's) original work and I license the work to the Kafka project under its open source license.

@ewasserman
Copy link
Contributor Author

Test unrelated to this PR failed. Closing and reopening.

@ewasserman ewasserman closed this Mar 31, 2016
@ewasserman
Copy link
Contributor Author

Tests passed locally. Re-opening.

@ewasserman ewasserman reopened this Mar 31, 2016
@ewasserman
Copy link
Contributor Author

closing request pending changes based on KIP-58 review.

@ewasserman ewasserman closed this Jun 6, 2016
@gwenshap
Copy link
Contributor

@ewasserman hey, the vote passed a while back, but I'm not sure where things went from there... was there another PR that got merged?

@gwenshap
Copy link
Contributor

never mind, found the second PR.

@ewasserman
Copy link
Contributor Author

Gwen, the second PR is stalled waiting for KIP-33 (KAFKA-3163) to be merged.

On Aug 16, 2016, at 9:34 AM, Gwen (Chen) Shapira notifications@github.com wrote:

never mind, found the second PR.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1168 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AFDbJNGS2rTCBeKcxED8SGYd-_hbuNbAks5qgeatgaJpZM4H8Tt3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants