Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14593: fix gradle build #14474

Closed
wants to merge 1 commit into from
Closed

Conversation

raboof
Copy link
Member

@raboof raboof commented Oct 3, 2023

Follow-up on 7553d3f/#13204 where it seems this occurrance was missed

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Follow-up on 7553d3f where it seems this occurrance was missed
@bmscomp
Copy link
Contributor

bmscomp commented Oct 3, 2023

Thank you for the pull request, can you please explain what was broken and how it was fixed

@bmscomp
Copy link
Contributor

bmscomp commented Oct 3, 2023

The build on local machine seems passing :)

@raboof
Copy link
Member Author

raboof commented Oct 3, 2023

at least gradle dependencyCheckAggregate fails for me:

> Configure project :
Starting build with version 3.7.0-SNAPSHOT (commit id 5f676cce) using Gradle 8.3, Java 17 and Scala 2.13.12
Build properties: maxParallelForks=16, maxScalacThreads=8, maxTestRetries=0

FAILURE: Build failed with an exception.

* Where:
Build file '/home/aengelen/dev/apache/kafka/build.gradle' line: 1914

* What went wrong:
A problem occurred evaluating root project 'kafka'.
> Project with path ':storage:api' could not be found in project ':tools'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 967ms

I didn't dive into exactly which targets work and which don't, but the error Project with path ':storage:api' could not be found in project ':tools'. seemed to match the recent change in 7553d3f/#13204 neatly, as it seems this occurrence of the renamed subproject was missed. Indeed with the change in this PR gradle dependencyCheckAggregate works again.

@bmscomp
Copy link
Contributor

bmscomp commented Oct 3, 2023

@raboof Thanks for the explanations

@raboof
Copy link
Member Author

raboof commented Oct 4, 2023

This fix was also in #14475 which has been merged

@raboof raboof closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants