KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. #14666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamossagar12
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for the PR @Lucent-Wong . I added a couple of comments. Let me know if those make sense.
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala
Outdated
Show resolved
Hide resolved
vamossagar12
approved these changes
Nov 21, 2023
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
Outdated
Show resolved
Hide resolved
|
hey @divijvaidya , @showuon would you be able to review this PR? This seems like a useful change and things look fine once I reviewed. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
In static membership protocol, the clientId and clientHost are not changed when static member is replaced. This will make it confused for user when describe the consumer group status as the info of the consumer instance does not match the config.
Committer Checklist (excluded from commit message)