KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand #15659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in ReassignPartitionsCommand
showuon
reviewed
Apr 6, 2024
Comment on lines
661
to
662
| throw new UnknownTopicOrPartitionException("Unable to find partition: " + | ||
| missingPartitions.stream().map(TopicPartition::toString).collect(Collectors.joining(", "))); |
There was a problem hiding this comment.
In ReassignPartitionsCommand#describeTopics, we wrap UnknownTopicOrPartitionException with ExecutionException. Maybe we should make it consistent by this pattern?
There was a problem hiding this comment.
Though I don't know why do we do this, but follow the pattern is a good choice. Thanks for the comment 😃
showuon
reviewed
Apr 6, 2024
Comment on lines
306
to
308
| UnknownTopicOrPartitionException exception = assertThrows(UnknownTopicOrPartitionException.class, | ||
| () -> getReplicaAssignmentForPartitions(adminClient, new HashSet<>(asList(new TopicPartition("foo", 0), new TopicPartition("foo", 10))))); | ||
| assertEquals("Unable to find partition: foo-10", exception.getMessage()); |
There was a problem hiding this comment.
If we change it to ExecutionException, should we change this? Ex:
Exception exception = assertThrows(ExecutionException.class,
() -> getReplicaAssignmentForPartitions(adminClient, new HashSet<>(asList(new TopicPartition("foo", 0), new TopicPartition("foo", 10)))));
Exception causeException = exception.getCause();
AssertTrue(causeException instanceof UnknownTopicOrPartitionException);
assertEquals("Unable to find partition: foo-10", causeException.getMessage());
showuon
reviewed
Apr 8, 2024
| @@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws Exception { | |||
|
|
|||
| assertEquals(assignments, | |||
| getReplicaAssignmentForPartitions(adminClient, new HashSet<>(asList(new TopicPartition("foo", 0), new TopicPartition("bar", 0))))); | |||
|
|
|||
| assignments.clear(); | |||
There was a problem hiding this comment.
Sorry, what's the purpose we explicitly clear assignments here? I think this is only used as local scope variable, we should not clear it.
There was a problem hiding this comment.
You're right, already removed it in the latest commit, many thanks 😃
|
Failed tests are unrelated. |
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…er in ReassignPartitionsCommand (apache#15659) Currently, when executing kafka-reassign-partitions.sh with the --execute option, if a partition number specified in the JSON file does not exist, this check occurs only when submitting the reassignments to alterPartitionReassignments on the server-side. We can perform this check in advance before submitting the reassignments to the server side. Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to KAFKA-16455
Currently, when executing kafka-reassign-partitions.sh with the --execute option, if a partition number specified in the JSON file does not exist, this check occurs only when submitting the reassignments to alterPartitionReassignments on the server-side.
We can perform this check in advance before submitting the reassignments to the server side.
Committer Checklist (excluded from commit message)