Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest #15885

Merged
merged 2 commits into from
May 15, 2024
Merged

KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest #15885

merged 2 commits into from
May 15, 2024

Commits on May 14, 2024

  1. KAFKA-16686: Improve waiting in TopicBasedRemoteLogMetadataManagerTest 

    Some tests in TopicBasedRemoteLogMetadataManagerTest flake because
`waitUntilConsumerCatchesUp` may break early before consumer manager has
caught up with all the events.

This change allows passing a spy object for `RemotePartitionMetadataStore`
down to `ConsumerTask` which allows the test code to ensure the methods
on it were invoked appropriate number of times before performing
assertions.

Refer
[Gradle Enterprise Report](https://ge.apache.org/scans/tests?search.timeZoneId=Europe%2FLondon&tests.container=org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest)
for more information on flakyness.
    @gaurav-narula
    gaurav-narula committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f918e4b View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @gaurav-narula
    gaurav-narula committed May 14, 2024
    Configuration menu
    Copy the full SHA
    58424dc View commit details
    Browse the repository at this point in the history