Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16660: reduce the check interval to speedup DelegationTokenRequestsTest #15907

Merged
merged 1 commit into from
May 10, 2024
Merged

KAFKA-16660: reduce the check interval to speedup DelegationTokenRequestsTest #15907

merged 1 commit into from
May 10, 2024

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented May 9, 2024 •
edited
Loading

related to https://issues.apache.org/jira/browse/KAFKA-16660

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@brandboat
Copy link
Member Author

Loop 131 times and all passed I=0; while ./gradlew core:test --tests DelegationTokenRequestsTest --rerun --fail-fast; do (( I=$I+1 )); echo "Completed run: $I"; sleep 1; done. But let's see if there is any surprise in jenkins.

chia7712
chia7712 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Contributor

before 16mins
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-15891/5/testReport/kafka.server/DelegationTokenRequestsTest/

after 1min 40s
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15907/1/testReport/kafka.server/DelegationTokenRequestsTest/

@chia7712 chia7712 merged commit 58c7369 into apache:trunk May 10, 2024
1 check failed
@brandboat brandboat deleted the KAFKA-16660 branch May 10, 2024 06:00
@showuon
Copy link
Contributor

showuon commented May 10, 2024

Thanks for the improvement!

@brandboat
Copy link
Member Author

Thanks @chia7712, @showuon , We've shortened CI runtime even more.

gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
@brandboat @gongxuanzhang
KAFKA-16660 reduce the check interval to speedup DelegationTokenReque…
fdd12c4 
…stsTest (apache#15907)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandboat @chia7712 @showuon