KAFKA-16766: offset fetch timeout exception in new consumer consistent with legacy #16125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Jun 1, 2024
…t with legacy (apache#16125) * Timeout exception fetching offsets * Tests
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
…t with legacy (apache#16125) * Timeout exception fetching offsets * Tests
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
…t with legacy (apache#16125) * Timeout exception fetching offsets * Tests
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…t with legacy (apache#16125) * Timeout exception fetching offsets * Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to ensure that a sensible error message is shown in TimeoutExceptions that may be thrown in offsetsForTimes, beginningOffsets and endOffsets, consistent with the message that the legacy consumer throws in these cases.
Before this fix, those functions timing out would throw a org.apache.kafka.common.errors.TimeoutException with message "java.util.concurrent.TimeoutException". This PR ensures a clear message is included (same message used by the LegacyKafkaConsumer)