KAFKA-16951 Notify TransactionManager of disconnects to proactively rediscover Coordinator #16390
+175
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ediscover Coordinator When disconnected from a transaction or consumer group coordinator, immediately perform a lookup to ensure we still have the correct node marked as the coordinator. This allows pro-active discovery of coordinator changes during broker restarts. Includes several test changes since the request/response flow has changed for disconnections and wait times, polling, so coordinator lookups all have slight adjustments.
|
@jolshan Does this seem like an appropriate way to speed up rediscovery of transactional coordinators? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disconnected from a transaction or consumer group coordinator, immediately perform a lookup to ensure we still have the correct node marked as the coordinator. This allows pro-active discovery of coordinator changes during broker restarts.
Includes several test changes since the request/response flow has changed for disconnections so wait times, polling, and coordinator lookups all have slight adjustments.
Committer Checklist (excluded from commit message)