KAFKA-17050: Revert group.version
#16482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jun 28, 2024
There was a problem hiding this comment.
@dajac thanks for this patch and sorry that we need to partially revert it in trunk for now. BTW, the following tests need to be updated tool.
| @@ -74,7 +74,6 @@ abstract class AbstractApiVersionsRequestTest(cluster: ClusterInstance) { | |||
| assertEquals(MetadataVersion.latestTesting().featureLevel(), apiVersionsResponse.data().supportedFeatures().find(MetadataVersion.FEATURE_NAME).maxVersion()) | |||
|
|
|||
| assertEquals(0, apiVersionsResponse.data().supportedFeatures().find(GroupVersion.FEATURE_NAME).minVersion()) | |||
There was a problem hiding this comment.
this should be removed too. Also, the expected value line#72 should be changed to 1 as group.version is reverted
|
@chia7712 Could you please take a second look? |
|
@dajac could you please fix the build error |
|
@chia7712 Done. Sorry for that. |
|
I guess |
|
@chia7712 Right. I just removed it. |
chia7712
approved these changes
Jul 1, 2024
|
There are a few failed tests that I need to fix… |
3 tasks
chirag-wadhwa5
pushed a commit
to chirag-wadhwa5/kafka
that referenced
this pull request
Jul 3, 2024
This patch partially reverts `group.version` in trunk. I kept the `GroupVersion` class but removed it from `Features` so it is not advertised. I also kept all the changes in the test framework. I removed the logic to require `group.version=1` to enable the new consumer rebalance protocol. The new protocol is enabled based on the static configuration. For the context, I prefer to revert it in trunk now so we don't forget to revert it in the 3.9 release. I will bring it back for the 4.0 release. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
3 tasks
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
This patch partially reverts `group.version` in trunk. I kept the `GroupVersion` class but removed it from `Features` so it is not advertised. I also kept all the changes in the test framework. I removed the logic to require `group.version=1` to enable the new consumer rebalance protocol. The new protocol is enabled based on the static configuration. For the context, I prefer to revert it in trunk now so we don't forget to revert it in the 3.9 release. I will bring it back for the 4.0 release. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partially reverts
group.versionin trunk. I kept theGroupVersionclass but removed it fromFeaturesso it is not advertised. I also kept all the changes in the test framework. I removed the logic to requiregroup.version=1to enable the new consumer rebalance protocol. The new protocol is enabled based on the static configuration.For the context, I prefer to revert it in trunk now so we don't forget to revert it in the 3.9 release. I will bring it back for the 4.0 release.
Committer Checklist (excluded from commit message)