Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage tool #16607

Merged
merged 3 commits into from
Jul 17, 2024
Merged

KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage tool #16607

merged 3 commits into from
Jul 17, 2024

Conversation

wernerdv
Copy link
Contributor

Remove print MetaPropertiesEnsemble from kafka-storage tool.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

chia7712
chia7712 reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wernerdv thanks for this patch. Please take a look at StorageToolTest

core/src/main/scala/kafka/tools/StorageTool.scala
@@ -530,7 +530,6 @@ object StorageTool extends Logging {
metaPropertiesEnsemble.verify(metaProperties.clusterId(), metaProperties.nodeId(),
util.EnumSet.noneOf(classOf[VerificationFlag]))

stream.println(s"metaPropertiesEnsemble=$metaPropertiesEnsemble")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testFormatEmptyDirectory and testFormatSucceedsIfAllDirectoriesAreAvailable need to be updated for this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccabe not sure whether this output is debugging-only? it was added by #14628, and the code was System.out.println(s"metaPropertiesEnsemble=${metaPropertiesEnsemble}"). Hence, I assume it was used to debug only before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccabe not sure whether this output is debugging-only? it was added by #14628, and the code was System.out.println(s"metaPropertiesEnsemble=${metaPropertiesEnsemble}"). Hence, I assume it was used to debug only before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gharris1727
gharris1727 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@gharris1727 gharris1727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this prevents the line from being printed from the storage tool.

@gharris1727
Copy link
Contributor

Test failures appear unrelated.

@gharris1727 gharris1727 merged commit a66a59f into apache:trunk Jul 17, 2024
1 check failed
gharris1727 pushed a commit to gharris1727/kafka that referenced this pull request Jul 17, 2024
@wernerdv @gharris1727
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
a7d3226 
…ool (apache#16607)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
gharris1727 pushed a commit to gharris1727/kafka that referenced this pull request Jul 17, 2024
@wernerdv @gharris1727
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
eedbdf5 
…ool (apache#16607)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
C0urante pushed a commit to C0urante/kafka that referenced this pull request Jul 17, 2024
@wernerdv @C0urante
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
0fc20a8 
…ool (apache#16607)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
gharris1727 added a commit that referenced this pull request Jul 18, 2024
@gharris1727 @wernerdv
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
abaecdf 
…ool (#16607) (3.7) (#16616)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
Co-authored-by: Dmitry Werner <grimekillah@gmail.com>
gharris1727 added a commit that referenced this pull request Jul 18, 2024
@gharris1727 @wernerdv
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
0172280 
…ool (#16607) (3.8) (#16617)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>

Co-authored-by: Dmitry Werner <grimekillah@gmail.com>
abhi-ksolves pushed a commit to ksolves/kafka that referenced this pull request Jul 31, 2024
@wernerdv @abhi-ksolves
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage t…
76a133b 
…ool (apache#16607)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
@wernerdv wernerdv deleted the KAFKA-17148 branch September 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 left review comments

@gharris1727 gharris1727 gharris1727 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wernerdv @gharris1727 @chia7712