Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17311: Add groupProtocol parameter to testClientInstanceId, testClientInstanceIdInvalidTimeout, and testClientInstanceIdNoTelemetryReporterRegistered #17135

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mingyen066
Copy link
Contributor

@mingyen066 mingyen066 commented Sep 9, 2024

The tests listed in the title should test both CLASSIC and CONSUMER group protocol. Without groupProtocol parameter, only CLASSIC group protocol will be tested.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mingyen066 mingyen066 changed the title KAFKA-17311: Include groupProtocol parameter to testClientInstanceId, testClientInstanceIdInvalidTimeout, and testClientInstanceIdNoTelemetryReporterRegistered KAFKA-17311: Add groupProtocol parameter to testClientInstanceId, testClientInstanceIdInvalidTimeout, and testClientInstanceIdNoTelemetryReporterRegistered Sep 9, 2024
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit e0bf580 into apache:trunk Sep 10, 2024
5 of 6 checks passed
mingyen066 added a commit to mingyen066/kafka that referenced this pull request Sep 10, 2024
…ClientInstanceIdInvalidTimeout, and testClientInstanceIdNoTelemetryReporterRegistered (apache#17135)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants