KAFKA-4262: Increase data volume in replication test #1982
Conversation
|
@benstopford Can you take a look? I think the test failed in https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/6086/testReport/junit/kafka.admin/ReassignPartitionsClusterTest/shouldExecuteThrottledReassignment/ because the reassign command that updates quota configuration completed before the throttle config update actually took effect. Rather than changing the implementation to fix the test, I have increased the amount of data produced by the test to avoid replication completing too soon. |
|
Thanks for spotting this Rajini. It'd be nice if we could do something more deterministic, but that's not going to be easy. Not for this test at least. I've raised a jira (4266) to add something more deterministic to the other throttling tests though, so they don't suffer this problem. |
To prevent test from completing without throttling before config change takes effect, produce more messages in the test. Author: Rajini Sivaram <rajinisivaram@googlemail.com> Reviewers: Ben Stopford <benstopford@gmail.com>, Ismael Juma <ismael@juma.me.uk> Closes #1982 from rajinisivaram/KAFKA-4262 (cherry picked from commit 5e4600a) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
|
Merged to trunk and 0.10.1 branches. |
…ompleted before start Increase the reliability of the one temporal comparison in ReassignPartitionsClusterTest by imposing a delay after ZK is updated. This should be more reliable than just increasing the amount of data. This relates to a previous PR: #1982 Author: Ben Stopford <benstopford@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #1997 from benstopford/KAFKA-4266
…ompleted before start Increase the reliability of the one temporal comparison in ReassignPartitionsClusterTest by imposing a delay after ZK is updated. This should be more reliable than just increasing the amount of data. This relates to a previous PR: apache/kafka#1982 Author: Ben Stopford <benstopford@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #1997 from benstopford/KAFKA-4266
To prevent test from completing without throttling before config change takes effect, produce more messages in the test.