Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-4303: Ensure commitSync does not block unnecessarily in poll without in-flight requests #2031

Closed
wants to merge 2 commits into from
Closed

KAFKA-4303: Ensure commitSync does not block unnecessarily in poll without in-flight requests #2031

wants to merge 2 commits into from

Conversation

hachikuji
Copy link

No description provided.

@guozhangwang
Copy link
Contributor

LGTM!

ijuma
ijuma approved these changes Oct 14, 2016
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@hachikuji hachikuji changed the title KAFKA-4303: Ensure commitSync does not block indefinitely in poll without in-flight requests KAFKA-4303: Ensure commitSync does not block unnecessarily in poll without in-flight requests Oct 14, 2016
@hachikuji
Copy link
Author

Thanks for the reviews. Merging to trunk and 0.10.1. I ran ConsumerBounceTest.testConsumptionWithBrokerFailures about 100 times with this patch without any recurrence of the bug. I'll continue running the test while I prepare the next release candidate.

asfgit pushed a commit that referenced this pull request Oct 14, 2016
KAFKA-4303; Ensure commitSync does not block unnecessarily in poll wi…
f287efa 
…thout in-flight requests

Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #2031 from hachikuji/KAFKA-4303

(cherry picked from commit 6199c62)
Signed-off-by: Jason Gustafson <jason@confluent.io>
@asfgit asfgit closed this in 6199c62 Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hachikuji @guozhangwang @ijuma