Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-4309: Allow "pluggable" properties in KafkaService in System Tests #2034

Closed
wants to merge 1 commit into from
Closed

KAFKA-4309: Allow "pluggable" properties in KafkaService in System Tests #2034

wants to merge 1 commit into from

Conversation

benstopford
Copy link
Contributor

No description provided.

@ijuma
Copy link
Contributor

ijuma commented Oct 21, 2016

LGTM, started a system tests run:

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/585/

Ewen said:
"it's ok, normally I'd put that into the template directly in a way that doesn't need any additional params on the service constructor, but this works".

@ijuma
Copy link
Contributor

ijuma commented Oct 21, 2016

System tests passed, merging to trunk and 0.10.1.

asfgit pushed a commit that referenced this pull request Oct 21, 2016
@benstopford @ijuma
KAFKA-4309; Allow "pluggable" properties in KafkaService in System Tests
3b0a8d6 
Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #2034 from benstopford/throttling-system-test-kafka-changes

(cherry picked from commit 2ac70c0)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@asfgit asfgit closed this in 2ac70c0 Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benstopford @ijuma