Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-4688: The Docker image should contain version 0.10.1.0 of Kafka #2424

Closed
wants to merge 2 commits into from
Closed

KAFKA-4688: The Docker image should contain version 0.10.1.0 of Kafka #2424

wants to merge 2 commits into from

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Jan 23, 2017

No description provided.

@ijuma
Copy link
Contributor

ijuma commented Jan 23, 2017

I think we also need to update vagrantfile. I'll take a look when I get home.

@ewencp
Copy link
Contributor

ewencp commented Jan 23, 2017

@cmccabe https://github.com/apache/kafka/blob/trunk/vagrant/base.sh#L64-L69 is where we install it for Vagrant VMs.

@ewencp
Copy link
Contributor

ewencp commented Jan 23, 2017

And I should mention that I made sure the corresponding URLs will be there -- in that case we haven't been relying on random mirrors and just used a reliable source of our own.

@asfbot
Copy link

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1117/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1120/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Jan 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1118/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Jan 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1118/
Test FAILed (JDK 8 and Scala 2.12).

ijuma
ijuma reviewed Jan 24, 2017
View reviewed changes
tests/docker/Dockerfile
@@ -28,6 +28,7 @@ ENV MIRROR="http://apache.cs.utah.edu/"
RUN wget -q "${MIRROR}kafka/0.8.2.2/kafka_2.10-0.8.2.2.tgz" -O "/tmp/kafka_2.10-0.8.2.2.tgz" && tar xfz /tmp/kafka_2.10-0.8.2.2.tgz -C /opt && mv "/opt/kafka_2.10-0.8.2.2" "/opt/kafka-0.8.2.2"
RUN wget -q "${MIRROR}kafka/0.9.0.1/kafka_2.10-0.9.0.1.tgz" -O "/tmp/kafka_2.10-0.9.0.1.tgz" && tar xfz /tmp/kafka_2.10-0.9.0.1.tgz -C /opt && mv "/opt/kafka_2.10-0.9.0.1" "/opt/kafka-0.9.0.1"
RUN wget -q "${MIRROR}kafka/0.10.0.1/kafka_2.10-0.10.0.1.tgz" -O "/tmp/kafka_2.10-0.10.0.1.tgz" && tar xfz /tmp/kafka_2.10-0.10.0.1.tgz -C /opt && mv "/opt/kafka_2.10-0.10.0.1" "/opt/kafka-0.10.0.1"
RUN wget -q "${MIRROR}kafka/0.10.1.0/kafka_2.10-0.10.1.0.tgz" -O "/tmp/kafka_2.10-0.10.1.0.tgz" && tar xfz /tmp/kafka_2.10-0.10.1.0.tgz -C /opt && mv "/opt/kafka_2.10-0.10.1.0" "/opt/kafka-0.10.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 0.10.1.1. Same for the other file.

ijuma
ijuma approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM. I changed the version to be 0.10.1.1 before merging to trunk and 0.10.2.

asfgit pushed a commit that referenced this pull request Jan 24, 2017
@cmccabe @ijuma
KAFKA-4688; Kafka 0.10.1.1 should be available in system tests
b676f51 
Author: Colin P. Mccabe <cmccabe@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #2424 from cmccabe/KAFKA-4688

(cherry picked from commit 5671806)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@asfgit asfgit closed this in 5671806 Jan 24, 2017
soenkeliebau pushed a commit to soenkeliebau/kafka that referenced this pull request Feb 7, 2017
@cmccabe @soenkeliebau
KAFKA-4688; Kafka 0.10.1.1 should be available in system tests
c222cff 
Author: Colin P. Mccabe <cmccabe@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes apache#2424 from cmccabe/KAFKA-4688
@cmccabe cmccabe deleted the KAFKA-4688 branch May 20, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cmccabe @ijuma @ewencp @asfbot