KAFKA-4646: Improve test coverage AbstractProcessorContext #2447
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| public static Properties minimalStreamsConfig() { | ||
| final Properties properties = new Properties(); | ||
| properties.put(StreamsConfig.APPLICATION_ID_CONFIG, UUID.randomUUID().toString()); | ||
| properties.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, "blah:9092"); |
There was a problem hiding this comment.
Nit: can we change blah to anyServer or something less blah-y? Otherwise LGTM
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @Test(expected = IllegalStateException.class) | ||
| public void shouldThrowIllegalStateExceptionOnRegisterWhenContextIsInitialized() throws Exception { | ||
| context.initialized(); | ||
| context.register(stateStore, false, null); |
There was a problem hiding this comment.
use try-catch instead of expected annotation -- not a single line test.
| @Test(expected = IllegalStateException.class) | ||
| public void shouldThrowIllegalStateExceptionOnTopicIfNoRecordContext() throws Exception { | ||
| context.setRecordContext(null); | ||
| context.topic(); |
| @Test(expected = IllegalStateException.class) | ||
| public void shouldThrowIllegalStateExceptionOnPartitionIfNoRecordContext() throws Exception { | ||
| context.setRecordContext(null); | ||
| context.partition(); |
| @Test(expected = IllegalStateException.class) | ||
| public void shouldThrowIllegalStateExceptionOnOffsetIfNoRecordContext() throws Exception { | ||
| context.setRecordContext(null); | ||
| context.offset(); |
| @Test(expected = IllegalStateException.class) | ||
| public void shouldThrowIllegalStateExceptionOnTimestampIfNoRecordContext() throws Exception { | ||
| context.setRecordContext(null); | ||
| context.timestamp(); |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Exception paths in `register()`, `topic()`, `partition()`, `offset()`, and `timestamp()`, were not covered by any existing tests Author: Damian Guy <damian.guy@gmail.com> Reviewers: Eno Thereska, Matthias J. Sax Closes apache#2447 from dguy/KAFKA-4646
Exception paths in
register(),topic(),partition(),offset(), andtimestamp(), were not covered by any existing tests