-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-4719: Consumption timeout should take into account producer request timeout #2479
Conversation
cc @ewencp Single run here: https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder-2/190/console. If successful, I'll repeat the test run a few more times. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@ewencp I ran the offset validation tests 5 times here: https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder-2/191/console. There was no recurrence of the specific failure that this patch is targeting. The two other failures are difficult to understand and do not seem to fit with the event output. If the changes here seem reasonable, I suggest we merge this patch for the increased logging visibility, and I can continue investigating the other failures. |
Oh, I almost forgot. One of the test failures seems to have been caused by this:
|
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
5 more runs, this time all passing: https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder-2/192/console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging to trunk and 0.10.2
…uest timeout Author: Jason Gustafson <jason@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes #2479 from hachikuji/KAFKA-4719 (cherry picked from commit 76550dd) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
…uest timeout Author: Jason Gustafson <jason@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#2479 from hachikuji/KAFKA-4719
No description provided.