KAFKA-4716: Send request to controller #2522
Conversation
|
[WiP] because system test has yet to run. |
|
Ok, I'll test the smoke test with 3 brokers first. I agree on the unit tests. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
enothereska
changed the title
|
Tests at scale pass for me on AWS. However, there appears to be a bug in the benchmark when I pass parameter "all" instead of each test. I'll open a separate JIRA for that, it is not related to this blocker. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -35,7 +35,7 @@ def __init__(self, test_context): | |||
|
|
|||
|
|
|||
| @cluster(num_nodes=9) | |||
| @matrix(test=["all"], scale=[1]) | |||
| @matrix(test=["produce", "consume", "count", "processstream", "processstreamwithsink", "processstreamwithstatestore", "processstreamwithcachedstatestore", "kstreamktablejoin", "kstreamkstreamjoin", "ktablektablejoin"], scale=[1, 2, 3]) | |||
There was a problem hiding this comment.
"all" was meant to be a convenience function when running locally, e.g., in a debugger. Not at scale. The reason is that a bit subtle. If I want to see how something like count scales, I don't want to mix the count run on one instance, with a random function that could still be running on another, e.g., consume. So all instances must be running the same function for the scale test to make sense.
There was a problem hiding this comment.
I'll add a comment on top of class.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
This PR fixes a blocker issue, where the streams client code cannot talk to the controller. It also enables a system test that was previously failing. This PR is for trunk only. A separate PR with just the fix (but not the tests) will be created for 0.10.2. Author: Eno Thereska <eno@confluent.io> Author: Eno Thereska <eno.thereska@gmail.com> Reviewers: Damian Guy, Ismael Juma, Matthias J. Sax, Guozhang Wang Closes apache#2522 from enothereska/KAFKA-4716-metadata
This PR fixes a blocker issue, where the streams client code cannot talk to the controller. It also enables a system test that was previously failing.
This PR is for trunk only. A separate PR with just the fix (but not the tests) will be created for 0.10.2.