Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-4859: Set shorter commit interval for integration tests with caching #2682

Closed
wants to merge 3 commits into from
Closed

KAFKA-4859: Set shorter commit interval for integration tests with caching #2682

wants to merge 3 commits into from

Conversation

guozhangwang
Copy link
Contributor

No description provided.

@guozhangwang guozhangwang mentioned this pull request Mar 14, 2017
Closed
@asfbot
Copy link

asfbot commented Mar 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2166/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Mar 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2163/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Mar 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2164/
Test PASSed (JDK 8 and Scala 2.12).

dguy
dguy reviewed Mar 14, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guozhangwang can we make the commit interval even smaller? i.e., is there any reason it can't be in 100 milliseconds?

@guozhangwang
Copy link
Contributor Author

@guozhangwang can we make the commit interval even smaller? i.e., is there any reason it can't be in 100 milliseconds?

Ack!

@asfbot
Copy link

asfbot commented Mar 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2198/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Mar 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2201/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Mar 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2199/
Test FAILed (JDK 8 and Scala 2.12).

dguy
dguy approved these changes Mar 16, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hachikuji
hachikuji approved these changes Mar 17, 2017
View reviewed changes
Copy link

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guozhangwang
Copy link
Contributor Author

Merged to trunk.

@asfgit asfgit closed this in cfda036 Mar 17, 2017
@guozhangwang guozhangwang deleted the K4859-cache-commit-interval branch July 15, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachikuji hachikuji hachikuji approved these changes

@dguy dguy dguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guozhangwang @asfbot @dguy @hachikuji