Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5040: Increase number of retries from the default of 0 #2819

Closed
wants to merge 3 commits into from
Closed

KAFKA-5040: Increase number of retries from the default of 0 #2819

wants to merge 3 commits into from

Conversation

enothereska
Copy link
Contributor

No description provided.

@enothereska
Copy link
Contributor Author

enothereska commented Apr 7, 2017 •
edited
Loading

This should also go into 0.10.2.1 to improve user experience under temporary broker failure. cc @mjsax @xvrl @ijuma

mjsax
mjsax approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2806/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2810/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2806/
Test PASSed (JDK 8 and Scala 2.12).

@ijuma
Copy link
Contributor

ijuma commented Apr 7, 2017

Can we have a JIRA so that it appears in the release notes?

dguy
dguy approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Contributor

ijuma commented Apr 7, 2017

Also, it would be good to have a note in upgrade.html.

@enothereska enothereska changed the title MINOR: Increase number of retries from the default of 0 KAFKA-5040: Increase number of retries from the default of 0 Apr 7, 2017
@enothereska
Copy link
Contributor Author

@ijuma opened JIRA and changed title. If the docs don't commit cleanly on 0.10.2 let me know and I can do a separate PR for just 0.10.2. Thanks.

ijuma
ijuma reviewed Apr 7, 2017
View reviewed changes
docs/streams.html Outdated
@@ -833,6 +833,7 @@
<li> parameter <code>zookeeper.connect</code> was deprecated; a Kafka Streams application does no longer interact with Zookeeper for topic management but uses the new broker admin protocol
(cf. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations#KIP-4-Commandlineandcentralizedadministrativeoperations-TopicAdminSchema.1">KIP-4, Section "Topic Admin Schema"</a>) </li>
<li> added many new parameters for metrics, security, and client configurations </li>
<li> of particular importance to improve the resiliency of a Kafka Streams application are two changes to default parameters of producer <code>retries</code> and consumer <code>max.poll.interval.ms</code></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right place or we do we need a 0.10.2.1 section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps docs should be changed in another pass once the doc structure for 0.10.2.1 is figured out?

@enothereska
Copy link
Contributor Author

@ijuma I undid the docs change. I will do another PR for that separately.

ijuma
ijuma approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should make sure to include this and other similar changes in the upgrade docs. This is typically done by updating upgrade.html, but I'll leave it for you to work out with @gwenshap.

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2817/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2817/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Apr 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2821/
Test PASSed (JDK 8 and Scala 2.11).

@ijuma
Copy link
Contributor

ijuma commented Apr 7, 2017

Merged to trunk and 0.10.2.

asfgit pushed a commit that referenced this pull request Apr 7, 2017
@ijuma
KAFKA-5040; Increase number of retries from the default of 0
47f9e8f 
Author: Eno Thereska <eno@confluent.io>

Reviewers: Damian Guy <damian.guy@gmail.com>, Matthias J. Sax <matthias@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #2819 from enothereska/minor-increase-retries

(cherry picked from commit e19bf3f)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@asfgit asfgit closed this in e19bf3f Apr 7, 2017
@enothereska enothereska deleted the minor-increase-retries branch April 7, 2017 12:44
guozhangwang
guozhangwang reviewed Apr 20, 2017
View reviewed changes
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guozhangwang guozhangwang guozhangwang left review comments

@ijuma ijuma ijuma approved these changes

@dguy dguy dguy approved these changes

@mjsax mjsax mjsax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enothereska @asfbot @ijuma @dguy @mjsax @guozhangwang