KAFKA-4422: Drop support for Scala 2.10 (KIP-119) #2956

ijuma · 2017-05-02T14:26:39Z

No description provided.

ijuma · 2017-05-02T14:26:50Z

Review by @ewencp.

ijuma · 2017-05-02T14:28:55Z

System tests started: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/876/

asfbot · 2017-05-02T15:25:00Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3370/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-02T15:43:46Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3361/
Test PASSed (JDK 8 and Scala 2.12).

ewencp

A couple of comments, but this LGTM as is

ewencp · 2017-05-02T16:55:24Z

build.gradle

@@ -466,20 +466,20 @@ def connectPkgs = ['connect:api', 'connect:runtime', 'connect:transforms', 'conn
 def pkgs = ['clients', 'examples', 'log4j-appender', 'tools', 'streams', 'streams:examples'] + connectPkgs

 tasks.create(name: "jarConnect", dependsOn: connectPkgs.collect { it + ":jar" }) {}
-tasks.create(name: "jarAll", dependsOn: ['jar_core_2_10', 'jar_core_2_11'] + pkgs.collect { it + ":jar" }) { }
+tasks.create(name: "jarAll", dependsOn: ['jar_core_2_11'] + pkgs.collect { it + ":jar" }) { }


Would it be worth refactoring all these to map a centralized list of the release versions? i.e. so we can centralize the lists release_versions = [ '2_11' ] and available_versions = [ '2_11', '2_12' ] in one place? It'll reduce the number of places we need to update these values in the future (which I assume we'll do when we finally drop JDK8 and bring 2_12 into the officially released versions).

That's a good suggestion. Added a commit that attempts this. Let me know what you think.

ewencp · 2017-05-02T16:58:48Z

tests/docker/Dockerfile

-RUN mkdir -p "/opt/kafka-0.9.0.1" && curl -s "${MIRROR}kafka/0.9.0.1/kafka_2.10-0.9.0.1.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.9.0.1"
-RUN mkdir -p "/opt/kafka-0.10.0.1" && curl -s "${MIRROR}kafka/0.10.0.1/kafka_2.10-0.10.0.1.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.10.0.1"
-RUN mkdir -p "/opt/kafka-0.10.1.1" && curl -s "${MIRROR}kafka/0.10.1.1/kafka_2.10-0.10.1.1.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.10.1.1"
+RUN mkdir -p "/opt/kafka-0.8.2.2" && curl -s "${MIRROR}kafka/0.8.2.2/kafka_2.11-0.8.2.2.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.8.2.2"


I think this change may not strictly be necessary. It'd be nice to know if things work without it -- we may eventually be faced with not being able to use the same scala version across all the versions of Kafka that we test.

That's a good point. I will revert the change to the 0.8.2.2 release so that we have one version on 2.10.

asfbot · 2017-05-02T21:44:47Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3386/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-02T22:41:47Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3383/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-05-02T22:54:06Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3392/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-02T23:36:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3395/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-03T00:26:20Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3397/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-03T00:48:50Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3392/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-05-03T01:12:32Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3401/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-03T01:33:56Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3403/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-03T01:41:41Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3394/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-05-05T10:18:35Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3529/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-05T11:14:26Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3532/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-05T11:31:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3535/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-05T11:38:03Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3526/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-05-05T12:22:14Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3529/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-05-05T12:34:32Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3538/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-07T23:19:56Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3624/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-08T00:24:58Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3621/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-05-08T00:25:31Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3630/
Test PASSed (JDK 8 and Scala 2.11).

ijuma · 2017-05-08T22:16:52Z

Green branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/885/

asfbot · 2017-05-09T13:11:54Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3677/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-09T14:21:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3683/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-09T14:26:13Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3673/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-05-09T15:30:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3680/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-09T15:35:22Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3676/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-05-09T16:42:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3686/
Test FAILed (JDK 8 and Scala 2.11).

ewencp

LGTM assuming the recent failures are due to other Jenkins flakiness -- can't tell anymore since the results seem to have already been cleaned up.

ijuma · 2017-05-10T21:44:03Z

retest this please

ijuma · 2017-05-10T21:44:29Z

Yeah, they were due to Jenkins flakiness. Running them again, just in case.

asfbot · 2017-05-10T21:46:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3723/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-05-10T22:54:32Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3729/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-05-10T23:03:08Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3719/
Test PASSed (JDK 8 and Scala 2.12).

ewencp approved these changes May 2, 2017

View reviewed changes

ijuma changed the title ~~KAFKA-4422: Drop support for Scala 2.10~~ KAFKA-4422: Drop support for Scala 2.10 (KIP-119) May 3, 2017

ijuma force-pushed the kafka-4422-drop-support-scala-2.10 branch from cdfe643 to 57a870d Compare May 5, 2017 10:17

ijuma added 5 commits May 8, 2017 00:14

KAFKA-4422: Drop support for Scala 2.10

4c7ca81

Use multiple Scala versions in Dockerfile

7d50fcc

Centralise management of Scala versions

8e0a505

set -ex in base.sh

064e016

Use multiple Scala versions

57f6a14

ijuma force-pushed the kafka-4422-drop-support-scala-2.10 branch from 1da2d3c to 57f6a14 Compare May 7, 2017 23:17

Fix regex for replacing . with _

d362ede

ijuma force-pushed the kafka-4422-drop-support-scala-2.10 branch from fbb47fb to d362ede Compare May 9, 2017 15:28

ewencp approved these changes May 10, 2017

View reviewed changes

asfgit closed this in bcf447e May 11, 2017

ijuma deleted the kafka-4422-drop-support-scala-2.10 branch June 18, 2017 09:33

KAFKA-4422: Drop support for Scala 2.10 (KIP-119) #2956

KAFKA-4422: Drop support for Scala 2.10 (KIP-119) #2956

Conversation

ijuma commented May 2, 2017

ijuma commented May 2, 2017

ijuma commented May 2, 2017 • edited Loading

asfbot commented May 2, 2017

asfbot commented May 2, 2017

ewencp left a comment

Choose a reason for hiding this comment

ewencp May 2, 2017

Choose a reason for hiding this comment

ijuma May 2, 2017

Choose a reason for hiding this comment

ewencp May 3, 2017

Choose a reason for hiding this comment

ewencp May 2, 2017

Choose a reason for hiding this comment

ijuma May 2, 2017

Choose a reason for hiding this comment

asfbot commented May 2, 2017

asfbot commented May 2, 2017

asfbot commented May 2, 2017

asfbot commented May 2, 2017

asfbot commented May 3, 2017

asfbot commented May 3, 2017

asfbot commented May 3, 2017

asfbot commented May 3, 2017

asfbot commented May 3, 2017

asfbot commented May 5, 2017

asfbot commented May 5, 2017

asfbot commented May 5, 2017

asfbot commented May 5, 2017

asfbot commented May 5, 2017

asfbot commented May 5, 2017

asfbot commented May 7, 2017

asfbot commented May 8, 2017

asfbot commented May 8, 2017

ijuma commented May 8, 2017

asfbot commented May 9, 2017

asfbot commented May 9, 2017

asfbot commented May 9, 2017

asfbot commented May 9, 2017

asfbot commented May 9, 2017

asfbot commented May 9, 2017

ewencp left a comment

Choose a reason for hiding this comment

ijuma commented May 10, 2017

ijuma commented May 10, 2017

asfbot commented May 10, 2017

asfbot commented May 10, 2017

asfbot commented May 10, 2017

ijuma commented May 2, 2017 •

edited

Loading