KAFKA-5252: Fix transient failures LogCleanerTest testCommitMarkerRemoval and testAbortMarkerRemoval

[hachikuji]

No description provided.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/3973/
Test FAILed (JDK 7 and Scala 2.11).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3961/
Test PASSed (JDK 8 and Scala 2.12).

[apurvam]

What was the bug that these changes fixed? Or was the time.milliseconds parameter making it flaky?

[hachikuji]

@apurvam It can happen that one of the log segments is created at the same timestamp as the call to doClean. If that happens, that segment won't be eligible for deletion. Since the intent of the test case is to make all segments eligible for deletion, I changed the test to use Long.MaxValue. In addition to guaranteeing all segments are eligible for deletion, it better conveys the intent of the test.

[apurvam]

Thanks for the explanation and the patch. LGTM.

So to rephrase what you said, all segments older than the deleteHorizonMs will be removed by cleaner.doClean right?

[guozhangwang]

LGTM.

[guozhangwang]

all segments older than the deleteHorizonMs will be removed by cleaner.doClean right?

More accurately, will be "considered" for cleaning :)