Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-5448: Change TimestampConverter configuration name to avoid conflicting with reserved 'type' configuration used by all Transformations #3342

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Jun 14, 2017

No description provided.

@ewencp
Copy link
Contributor Author

ewencp commented Jun 14, 2017

@dbtucker @hachikuji @gwenshap Pretty simple fix. I tested by adding

transforms=hoist,timestamp,convert
transforms.hoist.type=org.apache.kafka.connect.transforms.HoistField$Value
transforms.hoist.field=value
transforms.timestamp.type=org.apache.kafka.connect.transforms.InsertField$Value
transforms.timestamp.timestamp.field=timestamp
transforms.convert.type=org.apache.kafka.connect.transforms.TimestampConverter$Value
transforms.convert.field=timestamp
transforms.convert.target.type=string
transforms.convert.format=yyyy MM dd HH mm ss SSS z

to the file source connector and inspecting the results and things work fine (though I wouldn't mind some additional verification). At some point we'll probably want some integration tests to be able to validate things like this end-to-end, but I added unit tests for all the transformations to validate that they at least don't have any obvious conflicts that would be caught just be creating the ConnectorConfig extended with the transformations.

@dbtucker
Copy link

Thanks, @ewencp . LGTM

@gwenshap
Copy link
Contributor

LGTM. Nice test collection :)

asfgit pushed a commit that referenced this pull request Jun 14, 2017
…flicting with reserved 'type' configuration used by all Transformations

Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: David Tucker, Gwen Shapira

Closes #3342 from ewencp/kafka-5448-change-timestamp-converter-config-name

(cherry picked from commit b760615)
Signed-off-by: Gwen Shapira <cshapi@gmail.com>
@asfgit asfgit closed this in b760615 Jun 14, 2017
@asfbot
Copy link

asfbot commented Jun 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5310/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Jun 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5326/
Test PASSed (JDK 7 and Scala 2.11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants