KAFKA-5623: ducktape kafka service: do not assume Service contains nu… #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewencp
reviewed
Jul 21, 2017
| @@ -191,7 +192,7 @@ def prop_file(self, node): | |||
| # TODO - clean up duplicate configuration logic | |||
| prop_file = cfg.render() | |||
| prop_file += self.render('kafka.properties', node=node, broker_id=self.idx(node), | |||
| security_config=self.security_config) | |||
| security_config=self.security_config, num_nodes=self.num_nodes) | |||
There was a problem hiding this comment.
Hmm, is this required? Normally render should automatically have access to all fields of the object it's being called on. I'm not sure why the security_config one is there either.
There was a problem hiding this comment.
No, it's not required. I'll remove it.
|
Yes, I tested with ducktape 0.6.0 as well as ducktape master |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
asfgit
pushed a commit
that referenced
this pull request
Jul 21, 2017
…m_nodes …m_nodes Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes #3557 from cmccabe/KAFKA-5623 (cherry picked from commit 9ae09e8) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 21, 2017
…m_nodes …m_nodes Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes #3557 from cmccabe/KAFKA-5623 (cherry picked from commit 9ae09e8) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m_nodes