MINOR: improvement on top of KAFKA-5793: Tighten up the semantics of the OutOfOrderSequenceException #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the OutOfOrderSequenceException
|
@apurvam @hachikuji |
hachikuji
reviewed
Sep 21, 2017
hachikuji
reviewed
Sep 21, 2017
| lastAckedOffset.put(batch.topicPartition, lastOffset); | ||
| } else { | ||
| log.debug("partition {} keeps lastOffset at {}", batch.topicPartition, lastOffset); |
There was a problem hiding this comment.
Maybe this should be trace level. I can imagine it being very spammy when you have a lot of partitions. Also, we usually capitalize the first word.
|
A bit late, but thanks for the patch. The improvements LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the condition in Sender#failBatch()
Added log in TransactionManager#updateLastAckedOffset()