KAFKA-6071: Use ZookeeperClient in LogManager #4089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrao
reviewed
Oct 19, 2017
| val topicConfigs = AdminUtils.fetchAllTopicConfigs(zkUtils).map { case (topic, configs) => | ||
| topic -> LogConfig.fromProps(defaultProps, configs) | ||
| } | ||
| val (topicConfigs, failed) = zkUtils.getLogConfigs(zkUtils.getAllTopicsInCluster, defaultProps) |
There was a problem hiding this comment.
The current behavior is to throw an exception if any ZK operation fails. We probably want to preserve this.
There was a problem hiding this comment.
@junrao Thanks for the review
I have included IllegalArgumentException if any failed topics while fetching configs. Updated the PR.
Not sure if IllegalArgumentException is not appropriate here.
There was a problem hiding this comment.
@omkreddy : Failed includes exception. We can just throw the one in the first failed.
There was a problem hiding this comment.
@junrao Updated the PR.
omkreddy
force-pushed
the
KAFKA-6071-ZK-LOGMANAGER
branch
from
0f19b38
to
22d8786
Compare
|
@omkreddy : Thanks for the patch. LGTM |
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Nov 16, 2017
Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Jun Rao <junrao@gmail.com> Closes apache#4089 from omkreddy/KAFKA-6071-ZK-LOGMANAGER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.