Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6101 Reconnecting to broker does not exponentially backoff #4118

Closed
wants to merge 3 commits into from
Closed

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Oct 23, 2017

No description provided.

@ijuma
Copy link
Contributor

ijuma commented Oct 23, 2017

Thanks @tedyu. I submitted a PR to also test exponential backoff in NetworkClientTest:

https://github.com/tedyu/kafka/pull/1

If that looks good to you, please merge and then I'll merge your PR.

Test exponential backoff in NetworkClientTest
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging to trunk and 1.0 branches.

asfgit pushed a commit that referenced this pull request Oct 23, 2017
Author: tedyu <yuzhihong@gmail.com>
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Soenke Liebau <soenke.liebau@opencore.com>, Ismael Juma <ismael@juma.me.uk>

Closes #4118 from tedyu/trunk

(cherry picked from commit 277fc92)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@asfgit asfgit closed this in 277fc92 Oct 23, 2017
jeqo pushed a commit to jeqo/kafka that referenced this pull request Nov 16, 2017
Author: tedyu <yuzhihong@gmail.com>
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Soenke Liebau <soenke.liebau@opencore.com>, Ismael Juma <ismael@juma.me.uk>

Closes apache#4118 from tedyu/trunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants