Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6284: Fixed system test for Connect REST API #4279

Closed
wants to merge 1 commit into from
Closed

KAFKA-6284: Fixed system test for Connect REST API #4279

wants to merge 1 commit into from

Conversation

mikkin
Copy link
Contributor

@mikkin mikkin commented Nov 30, 2017

topics.regex was added in KAFKA-3073. This change fixes the test that invokes /validate to ensure that all the configdefs are returned as expected.

@mikkin
Copy link
Contributor Author

mikkin commented Nov 30, 2017

@ewencp / @rhauch -- please review. I've verified that system tests for connect rest pass locally.

rhauch
rhauch approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hachikuji
hachikuji approved these changes Nov 30, 2017
View reviewed changes
Copy link

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ewencp
ewencp approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@asfgit asfgit closed this in 18e3448 Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewencp ewencp ewencp approved these changes

@rhauch rhauch rhauch approved these changes

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
connect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikkin @ewencp @rhauch @hachikuji @kkonstantine