KAFKA-6300 SelectorTest may fail with ConcurrentModificationException #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is continuation of #4288 |
rajinisivaram
approved these changes
Dec 6, 2017
There was a problem hiding this comment.
@tedyu Thanks for the PR, LGTM.
Will merge after the builds pass.
asfgit
pushed a commit
that referenced
this pull request
Dec 6, 2017
Synchronization is added w.r.t. sockets ArrayList to avoid ConcurrentModificationException Author: tedyu <yuzhihong@gmail.com> Reviewers: Viktor Somogyi <viktorsomogyi@gmail.com>, Rajini Sivaram <rajinisivaram@googlemail.com> Closes #4299 from tedyu/trunk (cherry picked from commit b690933) Signed-off-by: Rajini Sivaram <rajinisivaram@googlemail.com>
|
Merged to trunk and 1.0 (since the new test which caused the intermittent failure is also in 1.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronization is added w.r.t. sockets ArrayList to avoid ConcurrentModificationException
Committer Checklist (excluded from commit message)