KAFKA-6422 Mirror maker will throw null pointer exception when the message value is null #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch, LGTM. Since this is a bug, would you mind creating a JIRA? That makes it easier for people who hit this to find the fix and which releases include it. |
|
@hachikuji will do that for sure. here is the task https://issues.apache.org/jira/browse/KAFKA-6422, let me know if there has anything else I can do. |
lisa2lisa
changed the title
lisa2lisa
changed the title
|
LGTM |
|
Looks good to me. |
|
retest this please |
|
I'm going to go ahead and merge this since the jenkins failures seem to be environmental. |
hachikuji
pushed a commit
that referenced
this pull request
Jan 8, 2018
…ssage value is null (#4387) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, James Cheng <jylcheng@yahoo.com>, Jason Gustafson <jason@confluent.io>
isolis
pushed a commit
to linkedin/kafka
that referenced
this pull request
Sep 13, 2018
KAFKA-6422 Mirror maker will throw null pointer exception when the message value is null (apache#4387) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, James Cheng <jylcheng@yahoo.com>, Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when enable trace level log in mirror maker, if the message value is null. it will throw null pointer exception and shutdown the mirror maker.