KAFKA-4247: Prevent CLASSPATH from beginning with a single colon #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Not sure what's going on with the skipped tests, but after scanning the results it appears they've been skipped for several past builds as well so I don't think they should be a problem. @rhauch, as long as that seems reasonable to you I'm ready to request a merge from a committer. |
|
@junrao seems ready to merge, mind taking a look? Looks like the build failures seem related to recent infrastructure changes and are not caused by the changes included in this PR. |
junrao
reviewed
Jan 9, 2018
bin/kafka-run-class.sh
Outdated
| @@ -260,6 +256,9 @@ if [ "x$GC_LOG_ENABLED" = "xtrue" ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # Remove a possible colon prefix from the classpath (happens at lines like `CLASSPATH="$CLASSPATH:$file"` when CLASSPATH is blank) | |||
| CLASSPATH=${CLASSPATH#:} | |||
There was a problem hiding this comment.
Perhaps just add a comment to explain what ${CLASSPATH#:} does.
|
@C0urante : Thanks for the update. LGTM |
|
Thanks @junrao! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different fix for problem addressed by #1953. Should prevent the CLASSPATH environment variable from being prefixed by a single colon before the JVM is invoked in the run-class script, which will then prevent the current working directory from being unintentionally included in the classpath when using the Reflections library.
If the current working directory should still be included in the classpath, it just needs to be explicitly specified either with its fully-qualified pathname or as a single dot (".").