Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Revert to ZooKeeper 3.4.10 due to ZOOKEEPER-2960 #4678

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Mar 10, 2018

It's a critical bug that only affects the server, but we
don't have an easy way to use 3.4.11 for the zookeeper
client only.

For reference the upgrade to ZooKeeper 3.4.11 was
done via 2652565.

Testing strategy: relying on existing tests and reverted
a change to a test to pass with 3.4.10.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested a review from junrao March 10, 2018 00:39
@ijuma
Copy link
Contributor Author

ijuma commented Mar 10, 2018

cc @dguy

It's a critical bug that only affects the server, but we
don't have an easy way to use 3.4.11 for the client
only.
@jeffchao
Copy link
Contributor

Nice, thanks!

Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ijuma, LGTM

@dguy
Copy link
Contributor

dguy commented Mar 10, 2018

retest this please

@dguy
Copy link
Contributor

dguy commented Mar 11, 2018

Is this good to merge @ijuma? or do you want to wait for @junrao to review?

@junrao
Copy link
Contributor

junrao commented Mar 12, 2018

@ijuma : Thanks for the patch. LGTM

@ijuma ijuma merged commit 825bfe5 into apache:trunk Mar 12, 2018
@ijuma ijuma deleted the revert-to-zk-3.4.10 branch March 12, 2018 11:41
ijuma added a commit that referenced this pull request Mar 12, 2018
It's a critical bug that only affects the server, but we
don't have an easy way to use 3.4.11 for the client
only.

Reviewers: Jun Rao <junrao@gmail.com>, Damian Guy <damian.guy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants