-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-6659: Improve error message if state store is not found #4732
KAFKA-6659: Improve error message if state store is not found #4732
Conversation
…nnected to the processor.
…nnected to the processor.
@mjsax please take a look. Thanks |
\cc @astubbs |
The problem with this new message is that most DSL users won’t know what it means. Would be food to somehow cover both bases? |
@astubbs I could change the text from explicit you to just "Please check the store has been connected to the processor." I think this would make it more generic or we use the terminology about adding state store? |
Maybe we can be more explicit. Something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Call for second review: @astubbs @guozhangwang @bbejeck @vvcephei
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, LGTM
If there are no further comments, I'll merge this soon. |
Merged to Thanks for the patch @perkss ! |
…#4732) Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Update the exception message thrown to state about the state store not found and suggest checking store has been connected to the processor.