Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6853: ZooKeeperRequestLatencyMs is incorrect #4961

Merged
merged 2 commits into from
May 3, 2018
Merged

KAFKA-6853: ZooKeeperRequestLatencyMs is incorrect #4961

merged 2 commits into from
May 3, 2018

Conversation

Fuud
Copy link
Contributor

@Fuud Fuud commented May 3, 2018 •
edited by ijuma
Loading

ResponseMetadata.responseTimeMs is always 0 or negative.

@Fuud
KAFKA-6853: ResponseMetadata calculates latency incorrectly (and ther…
badb32b 
…efore ZooKeeperRequestLatencyMs is incorrect)
@ijuma
Copy link
Contributor

ijuma commented May 3, 2018

Good catch. Can you please update MetricsTest.verifyBrokerZkMetrics to verify that the number is >= 0 in the first place? That should fail before the patch and pass after.

@ijuma
Copy link
Contributor

ijuma commented May 3, 2018

I added the test.

ijuma
ijuma approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajinisivaram
rajinisivaram approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fuud @ijuma Thanks for the PR, LGTM

@ijuma ijuma changed the title KAFKA-6853: ResponseMetadata calculates latency incorrectly KAFKA-6853: ResponseMetadata.responseTimeMs is incorrect May 3, 2018
@ijuma ijuma changed the title KAFKA-6853: ResponseMetadata.responseTimeMs is incorrect KAFKA-6853: ZooKeeperRequestLatencyMs is incorrect May 3, 2018
@ijuma ijuma merged commit de14783 into apache:trunk May 3, 2018
ijuma pushed a commit that referenced this pull request May 3, 2018
@Fuud @ijuma
KAFKA-6853: ZooKeeperRequestLatencyMs is incorrect (#4961)
22d6e21 
ResponseMetadata.responseTimeMs is always 0 or negative.

Reviewers: Rajini Sivaram <rajinisivaram@gmail.com>, Ismael Juma <ismael@juma.me.uk>
ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
@Fuud @ying-zheng
KAFKA-6853: ZooKeeperRequestLatencyMs is incorrect (apache#4961)
da226c9 
ResponseMetadata.responseTimeMs is always 0 or negative.

Reviewers: Rajini Sivaram <rajinisivaram@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

@rajinisivaram rajinisivaram rajinisivaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fuud @ijuma @rajinisivaram