Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6620: Documentation about 'exactly_once' doesn't mention 'transaction.state.log.min.isr' #5434

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

dongjinleekr
Copy link
Contributor

Add note on transaction.state.log.min.isr property, which can cause a problem when transaction.state.log.replication.factor is set to 1 for development without changing it to 1.

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Call for second review @guozhangwang

@mjsax
Copy link
Member

mjsax commented Aug 1, 2018

Retest this please.

@dongjinleekr
Copy link
Contributor Author

@mjsax Could you include this PR in 2.1.0?

@guozhangwang guozhangwang merged commit e7b6d65 into apache:trunk Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants