KAFKA-7310: Fix testUnsupportedCiphers to work with Java 11 #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
changed the title
Java 11 supports TLS 1.3 which has different cipher names than previous TLS versions so the simplistic way of choosing ciphers is not guaranteed to work. Fix it by configuring the context to use TLS 1.2.
ijuma
force-pushed
the
kafka-7310-ssl-java-11
branch
from
b9558c8
to
c0730bc
Compare
rajinisivaram
approved these changes
Aug 29, 2018
|
Merging to trunk. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…apache#5570) Java 11 supports TLS 1.3 which has different cipher names than previous TLS versions so the simplistic way of choosing ciphers is not guaranteed to work. Fix it by configuring the context to use TLS 1.2. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 11 supports TLS 1.3 which has different cipher names than
previous TLS versions so the simplistic way of choosing ciphers
is not guaranteed to work. Fix it by configuring the context
to use TLS 1.2.
Committer Checklist (excluded from commit message)