KAFKA-7620: Fix restart logic for TTLs in WorkerConfigTransformer #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayokota
changed the title
|
@ewencp , could I kindly get a review? Thanks in advance! |
mageshn
reviewed
Nov 21, 2018
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java
Show resolved
Hide resolved
|
Thanks @mageshn ! I've incorporated your feedback. |
ewencp
reviewed
Nov 27, 2018
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java
Show resolved
Hide resolved
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java
Outdated
Show resolved
Hide resolved
|
@ewencp , thanks for the review! I've incorporated your feedback. Let me know if there are any other changes you would like. |
ewencp
approved these changes
Nov 28, 2018
ewencp
pushed a commit
that referenced
this pull request
Nov 28, 2018
The restart logic for TTLs in `WorkerConfigTransformer` was broken when trying to make it toggle-able. Accessing the toggle through the `Herder` causes the same code to be called recursively. This fix just accesses the toggle by simply looking in the properties map that is passed to `WorkerConfigTransformer`. Author: Robert Yokota <rayokota@gmail.com> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #5914 from rayokota/KAFKA-7620 (cherry picked from commit a2e87fe) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
ewencp
pushed a commit
that referenced
this pull request
Nov 28, 2018
The restart logic for TTLs in `WorkerConfigTransformer` was broken when trying to make it toggle-able. Accessing the toggle through the `Herder` causes the same code to be called recursively. This fix just accesses the toggle by simply looking in the properties map that is passed to `WorkerConfigTransformer`. Author: Robert Yokota <rayokota@gmail.com> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #5914 from rayokota/KAFKA-7620 (cherry picked from commit a2e87fe) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
The restart logic for TTLs in `WorkerConfigTransformer` was broken when trying to make it toggle-able. Accessing the toggle through the `Herder` causes the same code to be called recursively. This fix just accesses the toggle by simply looking in the properties map that is passed to `WorkerConfigTransformer`. Author: Robert Yokota <rayokota@gmail.com> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#5914 from rayokota/KAFKA-7620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restart logic for TTLs in
WorkerConfigTransformerwas broken when trying to make it toggle-able. Accessing the toggle through theHerdercauses the same code to be called recursively. This fix just accesses the toggle by simply looking in the properties map that is passed toWorkerConfigTransformer.Committer Checklist (excluded from commit message)