KAFKA-7687: Print batch level information in DumpLogSegments #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Nov 30, 2018
| @@ -289,7 +289,7 @@ object DumpLogSegments { | |||
| } | |||
| lastOffset = record.offset | |||
|
|
|||
| print("offset: " + record.offset + " position: " + validBytes + | |||
| print("- offset: " + record.offset + " position: " + validBytes + | |||
There was a problem hiding this comment.
I think there's some redundant information that we can exclude if we are printing the batch info: position, timestamp type, magic version, compression codec. Below we can also exclude the producerId, epoch, and the transactional flag.
Also, what do you think about using | instead of -?
hachikuji
reviewed
Nov 30, 2018
| print(" producerId: " + batch.producerId + " producerEpoch: " + batch.producerEpoch + " sequence: " + record.sequence + | ||
| " isTransactional: " + batch.isTransactional + | ||
| " headerKeys: " + record.headers.map(_.key).mkString("[", ",", "]")) | ||
| print(" sequence: " + record.sequence + " headerKeys: " + record.headers.map(_.key).mkString("[", ",", "]")) | ||
| } else { | ||
| print(" crc: " + record.checksumOrNull) |
There was a problem hiding this comment.
The old format still has individual record level checksums. I think it would make sense to add back " isvalid: " + record.isValid here.
| " " + batch.timestampType + ": " + record.timestamp + " isvalid: " + record.isValid + | ||
| " keysize: " + record.keySize + " valuesize: " + record.valueSize + " magic: " + batch.magic + | ||
| " compresscodec: " + batch.compressionType) | ||
| print(s"$INDENT offset: ${record.offset} keysize: ${record.keySize} valuesize: ${record.valueSize}") |
There was a problem hiding this comment.
On second thought, the timestamp is a per-record field, so can we add batch.timestampType + ": " + record.timestamp back to this string?
…p iterating DumpLogSegment should be able to print batch level information when deep-iteration is specified
|
@hachikuji That's fine to me. Looks it's a more reasonable change. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…p iterating (apache#5976) DumpLogSegments should print batch level information when deep-iteration is specified. Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DumpLogSegment should be able to print batch level information when deep-iteration is specified
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)